Skip to content

Conversation

@ekes
Copy link
Member

@ekes ekes commented Nov 28, 2025

Description to follow.

@ekes
Copy link
Member Author

ekes commented Nov 28, 2025

Composite address lookup configuration:

Without patch what is displayed is the hard coded fields.

Afterwards the fields have the values from the config in the render array. So no I don't know how the help text should even be displayed; and yes the hide/invisible title will also be moved.

If the fields are left blank the defaults are used.

There is one upgrade issue related to that. The title field is compulsory, but the default in the module has always been used, so whatever was typed in this field has not been displayed on the front end.

[images might be missing, if so I'll upload when I'm not in a train]

@ekes
Copy link
Member Author

ekes commented Nov 29, 2025

1) Drupal\Tests\localgov_forms_date\MultipageTest::testReturnToPreviousPage
Exception: Deprecated function: _webform_datetime_date(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead
require_once()() (Line: 30)

Is in webform module itself.

And the other fail is eslint. We're not touching javascript here.

@msayoung
Copy link
Member

msayoung commented Dec 2, 2025

To test, addd the LocalGov address lookup field to a form.

Note the title of the Lookup field is "Postcode or street" and the description text "Enter a postcode..."

If you enter a different value in to the address_lookup description it does not appear.

With this fix, this is replaced with the value you enter.

I'm probably missing something @ekes but I don't see where to update the title in the UI ?

@ekes
Copy link
Member Author

ekes commented Dec 4, 2025

image

In the image:

"Enter the postcode and..." is the title.
"If you cannot find an..." is the description.

@ekes
Copy link
Member Author

ekes commented Dec 11, 2025

Merged on d.o

@ekes ekes closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants