Apply code-formatter and fix several typos and deprecations#516
Open
sschulz92 wants to merge 9 commits intolocationtech:masterfrom
Open
Apply code-formatter and fix several typos and deprecations#516sschulz92 wants to merge 9 commits intolocationtech:masterfrom
sschulz92 wants to merge 9 commits intolocationtech:masterfrom
Conversation
in module 'org.locationtech.udig.catalog.ui'
fgdrf
reviewed
Oct 8, 2021
| @Override | ||
| public void selectionChanged( IAction action, ISelection selection ) { | ||
| try { | ||
| this.selection = (IStructuredSelection) selection; |
Contributor
There was a problem hiding this comment.
This is a functional changes, why are selection events ignored?
Contributor
Author
There was a problem hiding this comment.
Eclipse showed a warnings that the variable selection was never used. As the member variable was private, it could not be accessed from outside. Therefore I removed the variable.
So no sub-classes available in the current codebase ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in module 'org.locationtech.udig.catalog.ui'