-
Notifications
You must be signed in to change notification settings - Fork 0
lockbook flatpak builder package #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure what goes here, you'll have to read a bit more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know what we need to put on this file so that's why i put that line there wezterm example
Parth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious if this works on your system
| @@ -0,0 +1,52 @@ | |||
| { | |||
| "app-id": "org.lockbook.Lockbook", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to use net.lockbook.Lockbook we own https://lockbook.net, and don't have .org.
| "--share=ipc", | ||
| "--filesystem=home:ro", | ||
| "--filesystem=xdg-config/wezterm", | ||
| "--socket=fallback-x11", | ||
| "--socket=wayland", | ||
| "--device=dri", | ||
| "--talk-name=org.freedesktop.Flatpak", | ||
| "--talk-name=org.freedesktop.Notifications", | ||
| "--share=network" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs more scrutiny, most of these are not valid for lockbook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i copied them from wezterm and before i read on the flatpak docs here
finish-args:
# X11 + XShm access
- --share=ipc
- --socket=fallback-x11
# Wayland access
- --socket=wayland
# GPU acceleration if needed
- --device=dri
# Needs to talk to the network:
- --share=network
# Needs to save files locally
- --filesystem=xdg-documents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling that this is a file that wezterm uses to generate the json file we're dealing with above, you should verify this, but I think if you look at those files that you linked me initially you'll find them using this template to substitute in the values for @URL@.
|
@Parth i created a new rust project for testing the app
|
@Parth i created file for the flatpak builder
org.lockbook.Lockbook.jsonand the one that we will push on flathuborg.lockbook.Lockbook.template.jsonthat's what wezterm did. and i createdlockbook.appdata.xmlbut i don't have any idea what we put there.