feat: add TrueSheetPeek component#730
Open
lodev09 wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ee58bb2 to
e13a6f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
TrueSheetPeekwrapper component that marks part of the content as the sheet's peek content. Its natively-measured height is included in thepeekdetent height (along with theheaderandfooterheights), so the collapsed size follows the actual content — noonLayoutjuggling.TrueSheetPeekViewFabric component (iOS/Android) that measures via native layout and reports to the sheet's detent calculator — no JS round tripheader + peek + footer,150fallback unchangedonLayout+ context feeding the vaul snap pointTrueSheetPeekbelongs at the top of the content (the sheet reveals from the top; only its height is used)MapScreenexample now uses['peek', 'auto', 1]with the heading as peek contentType of Change
Test Plan
yarn typecheck,yarn lint,yarn test(44 passed)MapScreenon iOS/Android: initial present at peek detent sizes to header + heading, resizes live when peek content changesChecklist