-
Notifications
You must be signed in to change notification settings - Fork 28
[FSTORE-2055] incremental training datasets #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f0d51f6
init
bubriks ad5fdde
Address review feedback: use heading-ID cross-references
bubriks aa0a92c
even_time td partitions
bubriks 5ae407e
compute_training_dataset_statistics
bubriks 31ca048
event time partitions
bubriks 14024dd
event_time improvements
bubriks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we recompute the training dataset statistics I think the transformation functions should use the new statistics of the training data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's intentional.
compute_training_dataset_statisticsonly refreshes the descriptive statistics the transformation statistics stay pinned, because the materialized data was already transformed with them.Refitting transformation statistics without rewriting the data would make new appends and serving inconsistent with what's on disk. To refit currently, rebuild the version with
insert_training_data(overwrite=True)or create a new TD version. I've added a runtime warning to make this explicit at the call site.Maybe we should look into improving stats further in the future, but i think it should probably be a new PR and maybe someone with more XP in this should do it :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with what you have mentioned, I did not think about the data that is already transformed. I am also not really sure what is the best way to to handle this case. We will leave it for now and handle it later.