add price impact panel#100
Open
gravityblast wants to merge 3 commits intomainfrom
Open
Conversation
0x-r4bbit
reviewed
May 8, 2026
Collaborator
0x-r4bbit
left a comment
0x-r4bbit
left a comment
There was a problem hiding this comment.
Seems like this is only updating the custom price impact with the last value in the modal, after the modal has been closed, resulting in the value always being "one value behind".
It's definitely a bug but not super critical at the moment because the UI isn't powered by a proper model yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #56
closes #57