Skip to content

add test-basic-module-cpp#17

Merged
dlipicar merged 2 commits into
masterfrom
add-basic-module-cpp
Apr 25, 2026
Merged

add test-basic-module-cpp#17
dlipicar merged 2 commits into
masterfrom
add-basic-module-cpp

Conversation

@dlipicar
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 24, 2026 22:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new test_basic_module_cpp “universal” test module implemented in pure C++ (std types + LogosMap/LogosList + StdLogosResult) intended to exercise the C++→Qt glue generation path, and wires it into the repo’s Nix flake outputs.

Changes:

  • Introduce test-basic-module-cpp module sources (header + implementation) covering a broad signature/return-type matrix, plus module metadata and CMake build entry.
  • Export the new module from flake.nix (modules/packages/default bundle).
  • Update flake.lock to newer pinned dependencies.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test-basic-module-cpp/src/test_basic_module_cpp_impl.h Declares the pure-C++ implementation surface consumed by the generator.
test-basic-module-cpp/src/test_basic_module_cpp_impl.cpp Implements the test methods and event emission helpers.
test-basic-module-cpp/metadata.json Registers the new module (universal interface) and its nix package metadata.
test-basic-module-cpp/CMakeLists.txt Adds build configuration for the new module via logos_module(...).
flake.nix Exposes test_basic_module_cpp as a flake output and includes it in the default bundle.
flake.lock Updates locked inputs to versions compatible with the new module/build setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test-basic-module-cpp/src/test_basic_module_cpp_impl.cpp
Comment thread test-basic-module-cpp/src/test_basic_module_cpp_impl.cpp Outdated
Comment thread flake.nix
Comment thread test-basic-module-cpp/src/test_basic_module_cpp_impl.cpp
@dlipicar dlipicar force-pushed the add-basic-module-cpp branch from 3cbae0d to 68c389b Compare April 25, 2026 01:40
@dlipicar dlipicar merged commit e235f51 into master Apr 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants