Open
Conversation
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
kares
suggested changes
Jan 25, 2022
Contributor
kares
left a comment
There was a problem hiding this comment.
👍 this is a sold start but in order to ship the feature needs more work:
- deprecate the
formatoption in favor of the codec setting format => codeclooks like a hack - would keepformatas is (just mark it obsolete)formatdefault (:default => 'json') should be removed- plugin should detect a
formatconfigured by user (!= nil) and use it - if both
codecandformatare user configured the plugin should error
(this is a bit tricky - happy to assist as/if needed when other pieces are done) - the new version should be a minor bump
(sorry for the late review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
Add support for executing codec for body of http request.
I don't know why it has not been done before, maybe there is a reason. Let me know if it is.
Regards