Fix stale sdkVersion and document slog handler#4
Merged
Conversation
sdkVersion was left at 0.9.4 through the 1.0.0 release, so the User-Agent header and embedded SDK metadata reported a stale version. Bump it to 1.0.1. Also document the integrations/logtideslog log/slog handler in the README, which was previously undocumented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the v1.0.0 release, addressing two items raised in review.
Fixed
sdkVersionwas left at"0.9.4"through the 1.0.0 release, so theUser-Agentheader and the embedded SDK metadata (metadata.sdk.version) reported a stale version. Bumped to1.0.1.Documentation
integrations/logtidesloglog/sloghandler was undocumented in the README. Added a section showing how to route existingsloglogging through LogTide, plus a feature bullet.Note on versioning
The 1.0.0 git tag is already cached by
proxy.golang.organd recorded in the immutablesum.golang.orgchecksum database, so moving it would breakgo get ...@v1.0.0with a checksum mismatch. This is therefore a fix-forward release: v1.0.1.Testing
go build ./...,go vet ./...,go test ./...all pass.