Prevent help box from creating horizontal scroll#182
Open
aJanuary wants to merge 1 commit intolostcarpark:mainfrom
Open
Prevent help box from creating horizontal scroll#182aJanuary wants to merge 1 commit intolostcarpark:mainfrom
aJanuary wants to merge 1 commit intolostcarpark:mainfrom
Conversation
Because the width of the help box is 100%, but it also has padding, using the default box sizing, the width is first calculated as 100% of it's container, and then the padding added _on top_ of that, making it wider than it's container. This causes a horizontal scrollbar to appear on small screens, making it hard to scroll with a finger. Changing the box sizing to `border-box` changes how it calculates the width so it no longer spills outside of it's container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the width of the help box is 100%, but it also has padding, using the default box sizing, the width is first calculated as 100% of it's container, and then the padding added on top of that, making it wider than it's container. This causes a horizontal scrollbar to appear on small screens, making it hard to scroll with a finger.
Changing the box sizing to
border-boxchanges how it calculates the width so it no longer spills outside of it's container.