Split the rest of the utils out and improve testing #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machshev
force-pushed
the
split-utils
branch
2 times, most recently
from
dd213fe to
a66dfc0
Compare
hcallahan-lowrisc
approved these changes
Sep 22, 2025
Contributor
hcallahan-lowrisc
left a comment
hcallahan-lowrisc
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the new tests, and explaining the magical pytest builtin fixtures to me!
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org> Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
Given the nature of tests, some things are implied or simplified to make the tests more readable. This rule checks for boolean passed as positional argument. Which makes sense for the main codebase, as flags passed as positional make it difficult to know what flag is being set. However in the tests it's common to assert against a boolean and noqa comments would make the tests needlessly messy. Disabling the rule globally for test files given the prevalence of this usecase. Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Fixes some regressions that occored while converting over to pathlib. These tests will also ensure the expected behaviour is preserved in the future. Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
machshev
force-pushed
the
split-utils
branch
from
a66dfc0 to
ceea848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish splitting out
utils/__init__.pyinto more descriptive groupings underutils/*, and add some corresponding tests.