This repository was archived by the owner on May 26, 2023. It is now read-only.
Open
Conversation
Jud
changed the title
Collaborator
|
That's quite a PR, nice work! I'll have a look at this once we have 1.3.2 released. Would you mind writing some documentation for this as well? IIRC transactions are currently not explained at all in the docs. |
Collaborator
|
Code LGTM. An example of how to use in the docs would be great. While you're at it, maybe we can also add an extra example of how Events work? |
Collaborator
|
@Jud ping for docs :-) |
Collaborator
Author
|
@bjornpost re: the docs, they are relatively unchanged. IMO this just makes the existing transaction code work like a casual observer would expect them to. I'll open another issue for cleaning up event docs. Edit: btw, we've been running this code in production since ~2015. May be some corner cases we're not running into, but generally works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base branch for #111 was deleted, so I'm opening a new PR with a new base branch.
(Fixes #56)