Add support for arbitrary calendar headers#56
Add support for arbitrary calendar headers#56nickgartmann wants to merge 2 commits intolpil:mainfrom
Conversation
lpil
left a comment
There was a problem hiding this comment.
Hello! The code looks good, thank you for the contribution. Some questions:
Is the headers key the design used in other ics libraries?
What would happen if the header key END or similar was used? It seems that many header values could produce invalid ics.
Would you mind updating the changelog?
|
After some research of other libs, it looks like they call them properties but also there is a finite list of properties that are supported (per: https://datatracker.ietf.org/doc/html/rfc5545#section-3.7). They are:
You have everything but |
|
That could work, though is it clear? What does the Ruby library do there? |
|
They define the settable properties manually and then loop through all of the calendar properties when serializing They call the property |
Adds ability to specify custom calendar headers (like METHOD) via options. This enables support for calendar features like RSVP buttons in email invites. From: lpil#56 Author: Nick Gartmann
In order to get a calendar invite sent via email to show RSVP buttons, the ics file must contain a
METHODheader which matches the method provided in theContent-Typeheader of its file attachment (See the first paragraph of the iMIP RFC: https://datatracker.ietf.org/doc/html/rfc6047#section-2.4)This can be achieved by inserting the headers manually after the ics has been generated, but this PR adds support for arbitrary headers to be added below the
PRODIDheader.