Draft
Conversation
Signed-off-by: Oliver Alvarado Rodriguez <oliver.alvarado-rodriguez@hpe.com>
…arams if they are None Signed-off-by: Oliver Alvarado Rodriguez <oliver.alvarado-rodriguez@hpe.com>
Contributor
Author
|
I can't assign a reviewer, so manually pinging @researcherben here for comments. |
Signed-off-by: Oliver Alvarado Rodriguez <oliver.alvarado-rodriguez@hpe.com>
Contributor
Author
|
I cleaned up the code a bit and added a new commit to explain some of my changes. No rush at taking a look, but just pinging you again to make you aware @researcherben. Thanks! |
Signed-off-by: Oliver Alvarado Rodriguez <oliver.alvarado-rodriguez@hpe.com>
Contributor
Author
|
I reverted a "fix" that removed "type" from being written to the nested "params". This "fix" is no longer needed since the issue is with the SST JSON parser and not AHP itself. I reverted it. The SST issue documenting the bug can be found here: sstsimulator/sst-core#1554. This also reverts the same change applied to |
Signed-off-by: Oliver Alvarado Rodriguez <oliver.alvarado-rodriguez@hpe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes changes to AHP's
__write_modelfunction to align it with SST's 15.1+ expected JSON parser. The two major changes this PR tackles follow: