feat: add precise pre-deployment workflow readiness checks#923
feat: add precise pre-deployment workflow readiness checks#923mertilginoglu merged 3 commits intostagingfrom
Conversation
cb30c69 to
1c78e77
Compare
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
1c78e77 to
09c496d
Compare
Not up to standards ⛔🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity |
🟢 Coverage 85.21% diff coverage · +0.62% coverage variation
Metric Results Coverage variation ✅ +0.62% coverage variation (-1.00%) Diff coverage ✅ 85.21% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (aace175) 9705 3916 40.35% Head commit (c139f2e) 9843 (+138) 4033 (+117) 40.97% (+0.62%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#923) 142 121 85.21% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
09c496d to
ca2710c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca2710c53d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
meryemefe
left a comment
There was a problem hiding this comment.
I reviewed and tested locally in detail. It looks very good!
Motivation
Related issue: #348
Deployments can currently be triggered immediately after a new commit is pushed, even if the corresponding
Buildworkflow for that exact branch and commit has not finished yet. In that case, deployment may fail because the required build artifacts do not exist yet.This change improves that flow by checking whether required pre-deployment workflows are ready for the exact revision being deployed and warning the user when they are not.
Description
requiredPreDeploymentWorkflowsper environment, including persistence, DTO changes, and the database migration.READY,WAITING,FAILED, orMISSING_RUN.Buildare still running, failed, or missingTesting Instructions
Prerequisites:
BuildDeployment Workflow Branchto a different branch than the source branch to verify the displayed source referenceFlow:
Buildfor the exact branch and commit is still running, failed, or missing.Screenshots
Checklist
General
Server
Client