Skip to content

fix: track deployment workflow runs#932

Merged
mertilginoglu merged 14 commits intostagingfrom
fix/github-track-deployment-workflow-runs
Mar 29, 2026
Merged

fix: track deployment workflow runs#932
mertilginoglu merged 14 commits intostagingfrom
fix/github-track-deployment-workflow-runs

Conversation

@mertilginoglu
Copy link
Copy Markdown
Contributor

Motivation

Helios deployments were not reliably linked to the GitHub workflow run that actually executed the deployment. That made it harder to keep deployment status in sync, to resolve cancellations and job-status lookups against the correct repository, and to match GitHub deployment events back to the active Helios deployment when branch names differed from the workflow branch.

Description

  • store workflow run metadata returned by the GitHub workflow dispatch endpoint on HeliosDeployment
  • request workflow run details during dispatch and add a dedicated WorkflowDispatchResult model
  • refresh redeploy decisions from the persisted workflow run status instead of relying only on the last stored deployment status
  • resolve workflow cancellation and job-status lookups through the deployment linked to the workflow run before falling back to repository context
  • improve GitHub deployment synchronization by preferring active unresolved Helios deployments and matching by SHA when the workflow branch differs from the deployed branch
  • add server-side tests for workflow dispatch result handling, deployment status refresh, and deployment sync matching

Testing Instructions

Prerequisites:

  • GitHub Account without having any additional access-rights (e.g. admin, owner)
  • A repository/environment setup in Helios with a deployment workflow
  • A branch and commit that can be deployed through the environment

Flow:

  1. Log in to Helios as a Developer.
  2. Start a deployment for an environment that uses a GitHub Actions deployment workflow.
  3. Verify that the created Helios receives workflowId from GitHub and saves it to the deployment.

Checklist

General

Server

  • Code is performant and follows best practices

@github-actions github-actions Bot added bug Something isn't working application-server size:XL labels Mar 24, 2026
@mertilginoglu mertilginoglu force-pushed the fix/github-track-deployment-workflow-runs branch from 74579e1 to 0a0d95b Compare March 24, 2026 15:08
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Mar 24, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.10% (target: -1.00%) 30.84%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d8b47d4) 8700 2971 34.15%
Head commit (b4b341d) 8772 (+72) 3004 (+33) 34.25% (+0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#932) 107 33 30.84%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@mertilginoglu mertilginoglu force-pushed the fix/github-track-deployment-workflow-runs branch from 0a0d95b to 5f4aec6 Compare March 24, 2026 15:19
@github-actions github-actions Bot added size:L and removed size:XL labels Mar 24, 2026
@mertilginoglu mertilginoglu force-pushed the fix/github-track-deployment-workflow-runs branch 2 times, most recently from 48c00fa to e9a48eb Compare March 24, 2026 15:46
@mertilginoglu mertilginoglu changed the title Fix/GitHub track deployment workflow runs fix: track deployment workflow runs Mar 24, 2026
@mertilginoglu mertilginoglu force-pushed the fix/github-track-deployment-workflow-runs branch from 5319b6a to 534bbb1 Compare March 25, 2026 18:05
@mertilginoglu mertilginoglu force-pushed the fix/github-track-deployment-workflow-runs branch from e57992f to 9df3129 Compare March 25, 2026 18:43
@github-actions github-actions Bot added size:XL and removed size:L labels Mar 26, 2026
…flow-runs' into fix/github-track-deployment-workflow-runs
@helios-aet helios-aet Bot deployed to test-server-3 March 27, 2026 17:13 Active
@meryemefe meryemefe self-requested a review March 29, 2026 13:07
Copy link
Copy Markdown
Contributor

@meryemefe meryemefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally, LGTM

@mertilginoglu mertilginoglu marked this pull request as ready for review March 29, 2026 15:17
@mertilginoglu mertilginoglu requested a review from a team as a code owner March 29, 2026 15:17
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4b341da96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mertilginoglu mertilginoglu merged commit 9d07e45 into staging Mar 29, 2026
17 of 18 checks passed
@mertilginoglu mertilginoglu deleted the fix/github-track-deployment-workflow-runs branch March 29, 2026 19:25
meryemefe added a commit that referenced this pull request Apr 4, 2026
Co-authored-by: Meryem Efe <meryemefe.cs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants