Skip to content

add Galsim coordinate offset #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elanaku wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add Galsim coordinate offset #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61c0f4d
add Galsim coordinate offset
elanaku Feb 25, 2026
38f18ea
Fix formatting
elanaku Feb 28, 2026
73c5491
Fix formatting
elanaku Feb 28, 2026
d9535fd
Change residual threshold on fit
elanaku Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions python/lsst/summit/utils/guiders/detection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,13 @@ def measureStarOnStamp(
star.runAperturePhotometry(dataBkgSub, apertureRadius, gain=gain, bkgStd=bkgStd)

# 4) Add centroid and shape in amplifier roi coordinates
star.xroi += cutout.xmin_original
star.yroi += cutout.ymin_original
# GalSim uses 1-based indexing where (1,1) is the
# center of pixel [0,0].Matplotlib's imshow with
# extent=(0,w,0,h) places pixel centers at half-integers.
# To align: subtract 0.5 to convert GalSim coords to
# matplotlib pixel-center coords.
star.xroi += cutout.xmin_original - 0.5
star.yroi += cutout.ymin_original - 0.5
return star


Expand Down
2 changes: 1 addition & 1 deletion python/lsst/summit/utils/guiders/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ def computeTrendMetrics(
global_std = float(mad_std(y))

fitter = RobustFitter()
fit_res = fitter.fit(x, y)
fit_res = fitter.fit(x, y, residualThreshold=3.0)

return GuiderDriftResult(
fit=fit_res,
Expand Down
Loading