Emit position of actual file size when watching#111
Open
th0m4s wants to merge 1 commit intolucagrulla:masterfrom
Open
Emit position of actual file size when watching#111th0m4s wants to merge 1 commit intolucagrulla:masterfrom
th0m4s wants to merge 1 commit intolucagrulla:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting to read a file from a specific position, I needed to know where to display a button to the user to load the start of the file, but I used a second fs.stat which led to some weird behaviours if the file is being written rapidly.
To counter that, I created an event, watch, which is emitted when the file is being read at a specific position (in the watch function), so I could use that number later to retrieve the start of the file.
I didn't find another idea for the name, be pleased to rename it if necessary.
Thanks in advance