Skip to content

Don't send empty messages#17

Open
patmaddox wants to merge 1 commit intolucidstack:masterfrom
patmaddox:dont-send-empty-messages
Open

Don't send empty messages#17
patmaddox wants to merge 1 commit intolucidstack:masterfrom
patmaddox:dont-send-empty-messages

Conversation

@patmaddox
Copy link
Copy Markdown

Fixes #16

@patmaddox
Copy link
Copy Markdown
Author

It is easy enough for the client to look for [] events and ignore them - I thought it made more sense for the library to not send empty events at all though. What do you think?

@patmaddox
Copy link
Copy Markdown
Author

Turns out this makes it less reliable - messages can stop getting sent after a while. I still think it probably doesn't make sense to send empty messages (I'm seeing thousands of empty messages at a time sometimes). I'm just not sure how to do that...

@thbar
Copy link
Copy Markdown
Collaborator

thbar commented May 9, 2021

@patmaddox the "empty messages" problem seems to be fixed by #15. I will incorporate it into my own fork at https://github.com/thbar/ex-portmidi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confused about event API, especially empty messages []

2 participants