Add support for objects with custom toString#116
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a small follow-up for #52.
This adds support for objects/classes that provide a custom
toString()method, matching the shape discussed in the issue. Normal object maps still use the existing key/value handling when the object has the defaultObject.prototype.toString.I know this may not be the right tradeoff for
clsx. In my local build, the output changed from 239 -> 277 B fordist/clsx.mjs, 245 -> 281 B fordist/clsx.js, and 305 -> 340 B fordist/clsx.min.js. If that size/perf tradeoff is not desirable, please feel free to close this PR.I used Node 20.20.2 for tests and bench. On my local Node 22.22.0 setup, the existing
uvu -r esmtest command fails before reaching this change.Testing
npx -y node@20.20.2 node_modules/.bin/uvu -r esm testnpm run buildnpx -y node@20.20.2 benchRefs #52