Skip to content

Fix EventSender leak in outbox consumer #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewwormald merged 2 commits into from
Mar 10, 2026
Merged

Fix EventSender leak in outbox consumer #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a557c8
Fix EventSender leak in outbox consumer
andrewwormald Mar 10, 2026
a89a4d5
Apply suggestion from @Copilot
andrewwormald Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions outbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,14 @@ func purgeOutbox(
return wait(ctx, pollingFrequency)
}

// Cache senders by topic to avoid creating a new connection per event.
senders := make(map[string]EventSender)
defer func() {
for _, s := range senders {
_ = s.Close()
}
}()

// Send the events to the EventStreamer.
for _, e := range events {
var outboxRecord outboxpb.OutboxRecord
Expand All @@ -140,9 +148,13 @@ func purgeOutbox(

t0 := clock.Now()
topic := headers[HeaderTopic]
producer, err := stream.NewSender(ctx, topic)
if err != nil {
return err
producer, ok := senders[topic]
if !ok {
producer, err = stream.NewSender(ctx, topic)
if err != nil {
return err
}
senders[topic] = producer
}

err = producer.Send(ctx, foreignID, eventType, headers)
Expand Down
Loading