FIX-#431: implement sampling threshold and edit tests and docs#432
Open
westernguy2 wants to merge 2 commits intolux-org:masterfrom
Open
FIX-#431: implement sampling threshold and edit tests and docs#432westernguy2 wants to merge 2 commits intolux-org:masterfrom
westernguy2 wants to merge 2 commits intolux-org:masterfrom
Conversation
Signed-off-by: Kunal Agarwal <kagarwal2@berkeley.edu>
dorisjlee
approved these changes
Nov 13, 2021
Member
|
The code changes look great. It seems like |
Signed-off-by: Kunal Agarwal <kagarwal2@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kunal Agarwal kagarwal2@berkeley.edu
Overview
I removed the sampling_cap and sampling_start from the config and
execute_sampling. Instead, I added asampling_thresh, which is a threshold for which we'd begin sampling. This threshold forces any data larger than the threshold to sample the data such that the sample is equal to the size specified by the threshold. More information can be found in the documentation that was edited as part of this PR.Changes
I edited
configandexecute_samplingto implement this fix. I also edited the tests to account for the removal of the old configs and the addition of the new one. I finally edited the documentation to reflect these changes.Example Output
The issue described in #431 should be fixed now.