Skip to content

Feat/ptp example#1617

Open
asdwjure wants to merge 61 commits intodevelopfrom
feat/ptp_example
Open

Feat/ptp example#1617
asdwjure wants to merge 61 commits intodevelopfrom
feat/ptp_example

Conversation

@asdwjure
Copy link
Copy Markdown

@asdwjure asdwjure commented Jan 9, 2026

Purpose

Add PTP example.

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

Summary by CodeRabbit

Release Notes

  • New Features

    • Added TIME_PTP frame synchronization mode for multi-device camera coordination.
  • Improvements

    • Updated multi-device frame synchronization examples to support both external and PTP synchronization modes.
    • Enhanced device initialization behavior when using PTP synchronization.
  • Tests

    • Added comprehensive integration tests for frame synchronization across multiple devices with external and PTP modes.

@asdwjure asdwjure changed the base branch from main to develop January 9, 2026 17:09
@asdwjure asdwjure force-pushed the feat/ptp_example branch 3 times, most recently from 956bc21 to be97b93 Compare January 14, 2026 09:23
@asdwjure asdwjure requested a review from moratom January 14, 2026 09:25
@asdwjure asdwjure force-pushed the feat/ptp_example branch 4 times, most recently from f9cf89f to 64e5c4a Compare January 29, 2026 10:46
Matevz Morato and others added 6 commits March 4, 2026 20:42
…erence

Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
@asdwjure asdwjure force-pushed the feat/ptp_example branch 2 times, most recently from bed8c0b to a453743 Compare March 4, 2026 19:51
Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
Copy link
Copy Markdown
Collaborator

@moratom moratom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should merge the PTP example with FSync if possible, otherwise extract common functionality to a third file and reuse (and name examples clearly _ptp _fsync).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge the fsync & ptp examples?
90% of the code should be the same.

If not, we should name them, separate the common parts in a separate file in MultiDevice.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will separate. We could combine the code but at the cost of higher example complexity and we want the examples to be as easy to understand as possible...

SYNC_THRESHOLD_SEC = 1.0 / (2 * TARGET_FPS) # Max drift to accept as "in sync"
SET_MANUAL_EXPOSURE = False # Set to True to use manual exposure settings
# DEVICE_INFOS: list[dai.DeviceInfo] = ["IP_MASTER", "IP_SLAVE_1"] # Insert the device IPs here, e.g.:
DEVICE_INFOS = [dai.DeviceInfo(ip) for ip in ["192.168.0.146", "192.168.0.149"]] # The master camera needs to be first here
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true also for PTP that master needs to be first?
In any case, we should remove specific IPs from the script.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, but havent tested if we reverse this...
I will remove the IPs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CamelCase for consistency

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


# "version if applicable"
set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+077602b7ebda52b86afe3fce4e289c449e6846f7")
set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+6caea117b7ae35099a5fe6723e21922c87e0b290")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RVC2 likely needs to be updated as well, as the enum is on the shared interface

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RVC2? Why?

Jure Rebernik and others added 8 commits March 5, 2026 13:13
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
sb-lxn added 27 commits April 7, 2026 18:12
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
…d ptp tests

Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
@sb-lxn sb-lxn force-pushed the feat/ptp_example branch from 621a7c8 to 331ad23 Compare April 16, 2026 06:42
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
@sb-lxn sb-lxn force-pushed the feat/ptp_example branch from 331ad23 to 5b6d60f Compare April 16, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants