Conversation
956bc21 to
be97b93
Compare
f9cf89f to
64e5c4a
Compare
…erence Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
bed8c0b to
a453743
Compare
Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
a453743 to
13ed5d1
Compare
Signed-off-by: Jure Rebernik <jure.rebernik@luxonis.com>
13ed5d1 to
cd6d4b5
Compare
moratom
left a comment
There was a problem hiding this comment.
Thanks!
We should merge the PTP example with FSync if possible, otherwise extract common functionality to a third file and reuse (and name examples clearly _ptp _fsync).
There was a problem hiding this comment.
Can we merge the fsync & ptp examples?
90% of the code should be the same.
If not, we should name them, separate the common parts in a separate file in MultiDevice.
There was a problem hiding this comment.
Ok, will separate. We could combine the code but at the cost of higher example complexity and we want the examples to be as easy to understand as possible...
| SYNC_THRESHOLD_SEC = 1.0 / (2 * TARGET_FPS) # Max drift to accept as "in sync" | ||
| SET_MANUAL_EXPOSURE = False # Set to True to use manual exposure settings | ||
| # DEVICE_INFOS: list[dai.DeviceInfo] = ["IP_MASTER", "IP_SLAVE_1"] # Insert the device IPs here, e.g.: | ||
| DEVICE_INFOS = [dai.DeviceInfo(ip) for ip in ["192.168.0.146", "192.168.0.149"]] # The master camera needs to be first here |
There was a problem hiding this comment.
Is this true also for PTP that master needs to be first?
In any case, we should remove specific IPs from the script.
There was a problem hiding this comment.
Not necessarily, but havent tested if we reverse this...
I will remove the IPs
|
|
||
| # "version if applicable" | ||
| set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+077602b7ebda52b86afe3fce4e289c449e6846f7") | ||
| set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+6caea117b7ae35099a5fe6723e21922c87e0b290") |
There was a problem hiding this comment.
RVC2 likely needs to be updated as well, as the enum is on the shared interface
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
…d ptp tests Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
This reverts commit bb6a950.
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
…to feat/ptp_example
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
621a7c8 to
331ad23
Compare
Signed-off-by: stas.bucik <stas.bucik@luxonis.com>
331ad23 to
5b6d60f
Compare
Purpose
Add PTP example.
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
Summary by CodeRabbit
Release Notes
New Features
Improvements
Tests