Open
Conversation
… viewer on Raspbian
liamHowatt
reviewed
May 15, 2025
Contributor
liamHowatt
left a comment
liamHowatt
left a comment
There was a problem hiding this comment.
Amazing! Nice job getting a PR together for all your progress 🎉
Feel free to open a PR in LVGL to add lv_glfw_window_get_glfw_window 🙂 and apply @kisvegabor's fix.
Author
|
Is it safe to remove the jsmn and b64 dependencies? I kept them in so no other code would break, but fastGLTF handles all of that now so they're not used at all within this viewer app. |
Contributor
|
Yes, please remove them. |
…sion from all source files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New shader patterned after the Khronos Sample Viewer GLSL, new json/binary reader using FastGLTF. Work in progress.
