Skip to content

Conversation

@yasemincidem
Copy link

@yasemincidem yasemincidem commented Nov 16, 2016

The component made work with also relative width (flex etc..)
For example:

<ProgressBar
          fillStyle={{}}
          backgroundStyle={{backgroundColor: '#cccccc', borderRadius: 2}}
          style={{marginTop: 10, width: 300}}
          progress={this.state.progress}
  />

if we change the width:300 to flex:1 at above sample as shown below, progress-bar will not work because there is no fixed width property on style prop.

<ProgressBar
          fillStyle={{}}
          backgroundStyle={{backgroundColor: '#cccccc', borderRadius: 2}}
          style={{marginTop: 10, flex:1}}
          progress={this.state.progress}
      />

we can find the progress-bars width ourselves through code. this pr aims to made the plugin work with relative widths also. by detecting the width of progress programatically.

@yasemincidem yasemincidem changed the title Flexbox used instead of fixed width so progressbar will be flexible. Flexbox used instead of fixed width. Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant