feat: add support for opensearch containers#30
Merged
james-lydtech merged 6 commits intoJun 24, 2025
Merged
Conversation
Luke-Campbell
commented
Jun 24, 2025
| .withEnv("discovery.type", OPENSEARCH_DISCOVERY_TYPE) | ||
| .withEnv("DISABLE_INSTALL_DEMO_CONFIG", "true") | ||
| .withEnv("DISABLE_SECURITY_PLUGIN", "true") | ||
| .withEnv("cluster.routing.allocation.disk.threshold_enabled", "false") |
Contributor
Author
There was a problem hiding this comment.
avoiding tests failing to create indexes - especially on CI platforms
https://stackoverflow.com/questions/40736462/aws-elasticsearchservice-index-create-block-exception
| @@ -109,6 +109,11 @@ | |||
| <artifactId>kafka</artifactId> | |||
| <version>${testcontainers.version}</version> | |||
| </dependency> | |||
Contributor
There was a problem hiding this comment.
Are these new dependencies actually needed?
Contributor
|
Needs some readme additions like we have for elastic just for future users please |
rgolder1
approved these changes
Jun 24, 2025
rgolder1
left a comment
rgolder1
left a comment
Contributor
There was a problem hiding this comment.
- Approved with minor comments.
- Could you add an entry to the CHANGELOG file please, new version will be 3.10.0?
- Note when merging the PR please ensure the merge commit starts 'feat' so that the minor version is indeed bumped.
| | opensearch.discovery.type | Whether to form a single node or multi node Opensearch cluster. | `single-node` | | ||
| | opensearch.container.logging.enabled | Whether to output the Opensearch Docker logs to the console. | `false` | | ||
|
|
||
| The container base URL can be obtained using the `OpensearchClient`: |
Contributor
There was a problem hiding this comment.
Typo: OpensearchClient -> OpensearchCtfClient
|
|
||
| Enable Opensearch via the property `opensearch.enabled`. Opensearch is available on port `9200`. | ||
|
|
||
| _note that `elasticsearch.enabled` must be `false` for the opensearch to container to start_ |
Contributor
There was a problem hiding this comment.
Minor typo:
"for the opensearch to container to start"
->
"for the Opensearch container to start"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.