feat: add option to bind outgoing connections to a specific interface #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `interface` configuration option to `doh-client` that allows users to specify a network interface for all outgoing DNS queries (including bootstrap and passthrough traffic).
Owner
|
I super love this feature. Please give me some time to review this. By the way, does it work correctly on dual-stack networks? I remembr Golang’s HTTP client uses Happy Eyeballs algorithm. (I could be wrong.) Is this new function compatible with it? |
Author
|
I totally forgot about that. You're right, binding to a specific local IP breaks the default Happy Eyeballs behavior. I'll update the PR with a custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
interfaceconfiguration option todoh-clientthat allows users to specify a network interface for all outgoing DNS queries (including bootstrap and passthrough traffic).