Skip to content

Static CMS migration#31

Open
m2creates wants to merge 7 commits intomainfrom
static-cms-migration
Open

Static CMS migration#31
m2creates wants to merge 7 commits intomainfrom
static-cms-migration

Conversation

@m2creates
Copy link
Copy Markdown
Owner

@m2creates m2creates commented Nov 28, 2023

BUGS

  • Previews don't load widgetFor('body') if they contain HTML/Nunjucks. Does getHTML() from ToastUI do anything to help? Or is it a React thing for "dangerous HTML"?
  • Previews don't display list widget contents
  • Preview URL button doesn't include defined slug from preview_url. Tested local, staging preview, and live.

QOL Notes to discuss with maintainer

  • ToastUI: Default to raw markdown or move toggle to TOOLBAR
  • ToastUI: disable font options, specifically H1 (controlled by template, unique field)

MIGRATION DEBT

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Nov 28, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 28, 2023

Deploy Preview for void-unicorn ready!

Name Link
🔨 Latest commit ac8f994
🔍 Latest deploy log https://app.netlify.com/sites/void-unicorn/deploys/65669f8a93bd340008b641c3
😎 Deploy Preview https://deploy-preview-31--void-unicorn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 100
Best Practices: 100
SEO: 93
PWA: 90
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant