Open
Conversation
|
I applied your fix and I can now see the AM and PM on the UI when I choose time. However, the value in onchanged or onsaved is captured without AM or PM. Here's my code: |
Author
|
@iesmail-znz Thanks for checking, I'll take a look. Could you please try to pass a controller as I shown in my example and check it's text? Sure that it works this way |
Author
|
@iesmail-znz I've pushed a fix and checked with your configuration - looks good now. Could you please confirm? |
|
I'm having the same problem @iesmail-znz has with the onChanged and onSaved. Is this gonna be merge/fix any time soon? |
|
I'm trying to print AM PM in console or inside a string but i can only be able to get the time but without AM PM, but in the ui i can able to see AM PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes inconsistent time formats when use
DateTimePickerType.timewith 12 hour format. In current version, inputs will show time in formatHH;mm auntil you edit it manually.So, when you use widget like this:
It will be shown like this when screen loaded


when you pick another time and click 'OK' label will be shown like this:
Also, when you use controller with current plugin version - it's text may be different based on - did you select another time or not. That's why I call
_effectiveController?.text = _sTime + _sPeriod;ininitValues()Also, it will throw an exception when you try to pass a controller like this:
this PR fixes it as well