Conversation
Globs and relative entry paths in hashup.json now anchor at the current working directory by default. Explicit baseDir values (top-level or per-entry) still resolve against configDir, so users who want the old behavior can set "baseDir": ".". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
📖 Docs preview: https://maastrich.github.io/hashup/branches/pr-22/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Globs and relative entry paths in
hashup.jsonnow resolve against the current working directory by default, instead of the config file's directory.Running
hashup --cwd ./pkgorcd pkg && hashupboth anchorsrc/**/*.tsat./pkg/— which is what most users expect when invoking from a subdirectory.Behavior matrix
baseDirnot set (default)baseDirin configentry.baseDirin config--base-dirCLI flagTo keep the old config-relative behavior, add
"baseDir": ".":{ "baseDir": ".", "entries": { "app": { "entry": "src/**/*.ts" } } }Test plan
tests/cli/run-modes.test.tscases:cwd = workDir+-c pkg/hashup.jsonmatches files inworkDir/src/, notworkDir/pkg/src/baseDir: "."in the config still anchors atconfigDir, recovering the old defaultvp test— 123/123 passingvp checkcleanDocs
docs/guide/cli.md— rewrote the resolution-rules block to spell out the new default and the four precedence tiers.🤖 Generated with Claude Code