Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-183
to
+199
| self.as_set = 1 << self.id | ||
| self.as_set = 1 << self.id | ||
| global _PRP_SET_ALL | ||
| _PRP_SET_ALL |= self.as_set | ||
| self.piece = rot.piece | ||
| self.rotation = rot | ||
| self.piece_id = self.piece.id | ||
| self.name = name | ||
| self.contact = pt | ||
| self.piece = rot.piece | ||
| self.rotation = rot | ||
| self.piece_id = self.piece.id | ||
| self.name = name | ||
| self.contact = pt | ||
| _PIECE_ROTATION_POINTS.append(self) | ||
|
|
||
| dy, dx = pt | ||
|
|
||
| self.tiles: list[Tile] = [] | ||
| self.adjacent: set[Tile] = set() | ||
| self.corners: set[Tile] = set() | ||
|
|
||
| for y, x in rot.tiles: | ||
| self.tiles.append((y - dy, x - dx)) | ||
|
|
||
| self.tiles.extend((y - dy, x - dx) for y, x in rot.tiles) |
Author
There was a problem hiding this comment.
Function _PieceRotationPoint.__init__ refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
Comment on lines
-225
to
+223
| def _create_piece(name: str, shape: list[list[int]]) -> Piece: | ||
| def _create_piece(name: str, shape: list[list[int]]) -> Piece: |
Author
There was a problem hiding this comment.
Function _create_piece refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-421
to
+419
| _PRP_REL_COORDS: set[Tile] = set() | ||
| for _pt in _PRP_WITH_REL_COORD: | ||
| _PRP_REL_COORDS.add(_pt) | ||
| _PRP_REL_COORDS: set[Tile] = set(_PRP_WITH_REL_COORD) |
Author
There was a problem hiding this comment.
Lines 421-423 refactored with the following changes:
- Convert for loop into set comprehension (
set-comprehension) - Replace identity comprehension with call to collection constructor (
identity-comprehension)
Comment on lines
-667
to
+663
| if isinstance(value, Move): | ||
| return self.is_equal(value) | ||
| else: | ||
| return False | ||
| return self.is_equal(value) if isinstance(value, Move) else False |
Author
There was a problem hiding this comment.
Function Move.__eq__ refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-717
to
+712
| self._state: list[_BoardState] = [] | ||
| self._tiles = np.zeros((20, 20), dtype=np.uint8) | ||
| self._n_players = n_players | ||
| self._state: list[_BoardState] = [] | ||
| self._tiles = np.zeros((20, 20), dtype=np.uint8) | ||
| self._n_players = n_players |
Author
There was a problem hiding this comment.
Function Board.__init__ refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
| } | ||
|
|
||
| def __init__(self, name: str="TileWeight", weight_map: str='wall_crawl', custom_weights: list[int | float]=None): | ||
| def __init__(self, name: str="TileWeight", weight_map: str='wall_crawl', custom_weights: list[int | float]=None): |
Author
There was a problem hiding this comment.
Function TileWeightEngine.__init__ refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Merge else clause's nested if statement into elif (
merge-else-if-into-elif) - Lift code into else after jump in control flow (
reintroduce-else)
| def get_matches_by_engine(self, engine: int) -> list[MatchData]: | ||
| filtered_matches = [x for x in self.match_data if engine in x.engines] | ||
| return filtered_matches | ||
| return [x for x in self.match_data if engine in x.engines] |
Author
There was a problem hiding this comment.
Function TournamentResults.get_matches_by_engine refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-138
to
+137
| if sort_dir != 'asc' and sort_dir != 'desc': | ||
| if sort_dir not in ['asc', 'desc']: |
Author
There was a problem hiding this comment.
Function TournamentResults.get_engine_rankings_display refactored with the following changes:
- Replace multiple comparisons of same variable with
inoperator (merge-comparisons)
Comment on lines
-187
to
+190
| if (len(engines) < 1): | ||
| if not engines: | ||
| raise Exception("Number of engines must be greater than 0") | ||
| if move_seconds <= 0: | ||
| raise Exception("Must allow greater than 0 seconds per move") | ||
|
|
Author
There was a problem hiding this comment.
Function Tournament.__init__ refactored with the following changes:
- Simplify sequence length comparison (
simplify-len-comparison)
Comment on lines
-230
to
+233
|
|
||
| self.move_seconds = move_seconds if move_seconds is not None else self._seconds | ||
| if self.move_seconds <= 0: | ||
| raise Exception("Must allow greater than 0 seconds per move") | ||
|
|
Author
There was a problem hiding this comment.
Function Tournament.play refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!