chore(search): drop retired Postgres document name search#4246
Draft
gbirman wants to merge 2 commits into
Draft
Conversation
Match document_name via match_phrase_prefix in the OpenSearch document query instead of the Postgres name_search ILIKE path, reusing the content query's owner/shared access filtering. Removes the slow owner-OR-ids ILIKE tail and the duplicated filter resolution.
Document name search runs in OpenSearch now, so remove the uncalled name_search::search_document_names path and drop the idx_document_name_trgm GIN index that backed its ILIKE query. Prunes the orphaned .sqlx cache entries.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Base automatically changed from
gbirman/macro-1989-search-move-name-search-into-opensearch
to
main
June 22, 2026 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4244; draft until that's validated in prod so reverting it stays cheap. Removes the retired Postgres document name search now that it runs in OpenSearch: drops the
idx_document_name_trgmGIN index (DROP INDEX CONCURRENTLY) and deletes the now-uncalledname_searchdocument path. Keeps thepg_trgmextension (other indexes use it); two of the four pruned.sqlxentries were pre-existing orphans swept bycargo sqlx prepare.