Сhanges in class Attribute. #64

HelenMamontova · 2025-12-12T16:30:54Z

The make function added to class Attribute.

declaration.

message.

…ssage.

codecov · 2025-12-12T16:39:39Z

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.77%. Comparing base (0032fcb) to head (0826ceb).

Files with missing lines	Patch %	Lines
src/attribute.cpp	0.00%	33 Missing and 1 partial ⚠️
src/error.cpp	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   30.35%   29.77%   -0.58%     
==========================================
  Files          20       20              
  Lines        1960     1998      +38     
  Branches     1422     1445      +23     
==========================================
  Hits          595      595              
- Misses        106      157      +51     
+ Partials     1259     1246      -13

Flag	Coverage Δ
Linux	`29.77% <0.00%> (-0.58%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

madf · 2025-12-15T14:30:18Z

src/attribute.cpp

+        valueType = ValueType::Encrypted;
+    else if (type == "octet")
+        valueType = ValueType::Bytes;
+    else if (type == "vsa")


You can skip this check because you have identical exceptions here and in the else branch.

src/attribute.cpp

madf · 2025-12-15T14:33:00Z

src/attribute.cpp

+            for (const auto& t : tok)
+                bytes.push_back(std::stoul(t));
+            return new Bytes(code, bytes);
+        }


There is no default variant. What will happen if the type is ChapPassword or VendorSpecific?

Or if the type is neither of the enum values?

madf · 2025-12-15T14:34:04Z

include/radproto/error.h

        suchAttributeCodeAlreadyExists,
-        suchAttributeNameWithAnotherTypeAlreadyExists
+        suchAttributeNameWithAnotherTypeAlreadyExists,
+        typeIsNotSupported


Where do you use this value?

added.

message function.

madf · 2025-12-21T11:31:37Z

include/radproto/error.h

        invalidAttributeCode,
        invalidAttributeSize,
        invalidAttributeType,
+        invalidValueTypeMember,


What does this error mean?

madf · 2025-12-21T11:33:39Z

src/attribute.cpp

 using Attribute = RadProto::Attribute;
+using ValueType = RadProto::Attribute::ValueType;
+
+ValueType parseValueType(const std::string& type)


Where is the declaration of this function? If it is local - move it to the anonymous namespace. If it is public - put a declaration in the header.

madf · 2025-12-21T11:34:39Z

include/radproto/attribute.h

            virtual std::vector<uint8_t> toVector(const std::string& secret, const std::array<uint8_t, 16>& auth) const = 0;
            virtual Attribute* clone() const = 0;
+
+            enum class ValueType : uint8_t


I don't see how this type is used in public interfaces. If it is only used internally - move it to the cpp-file.

madf · 2025-12-21T11:35:13Z

src/attribute.cpp

+    else if (type == "vsa")
+       throw RadProto::Exception(RadProto::Error::typeIsNotSupported);
+    else
+       throw RadProto::Exception(RadProto::Error::invalidAttributeType);


I think, the wording here should be invalidValueType, right?

function message.

changed in parseValueType function. Variant default changed in switch in make function.

Error.

namespace.

madf · 2025-12-25T14:55:15Z

It would be nice to have tests for new function.

case ValueType::IpAddress and case ValueType Bytes changed in the function make.

…Test.

…eger.

TypeEncrypted.

HelenMamontova added 7 commits December 8, 2025 15:19

The invalidAttributeType added to enum class Error declaration.

ec42e11

The enum class ValueType and function make added to the class Attribute

273e007

declaration.

The case Error::invalidAttributeType added to switch in the function

3710e59

message.

Function Attribute::make definition added.

d7ad025

The case Error::typeIsNotSupported added to switch in the function me…

735836f

…ssage.

Exception added if type == vsa in the function make.

d964a8e

The typeIsNotSupported added to enum class Error declaration.

0826ceb

madf requested changes Dec 15, 2025

View reviewed changes

HelenMamontova added 6 commits December 16, 2025 13:58

The "vsa" check removed in make function make.

d500b09

The parseValueType function definition and call in the function make

514d485

added.

The variant default added to switch(valueType).

30ed640

Case Error::invalidValueTypeMember and error message added to the

906bdbf

message function.

The element invalidValueTypeMember added to enum class Error.

353e0da

The check "vsa" added to parseValueType function.

4022d0f

madf requested changes Dec 21, 2025

View reviewed changes

HelenMamontova added 7 commits December 22, 2025 14:16

The case Error::invalidValueTypeMember and error message changed in the

51263e8

function message.

The throw RadProto::Exception(RadProto::Error::invalidAttributeType)

46976a1

changed in parseValueType function. Variant default changed in switch in make function.

The invalidValueTypeMember changed to invalidValueType in enum class

8d6e68f

Error.

The parseValueType function declaration added.

57868ec

The enum class ValueType added, using ValueType removed.

29e7b8b

The enum class ValueType removed.

fa61b6d

The parseValueType function and enum class ValueType moved to anonymous

2d1b0ff

namespace.

HelenMamontova added 6 commits January 13, 2026 14:29

The invalidHexStringLength added to enum class Error.

9b4966c

The case Error::invalidHexStringLength added in the function message.

c3826f2

The header file <iostream> removed, function parseValueType fixed. The

d814d73

case ValueType::IpAddress and case ValueType Bytes changed in the function make.

The test suite AttributeMakeTests added.

8f32fec

The tests for methods of class String added to test case TypeStringTest.

1319b72

The tests for methods of class Integer added to test case TypeInteger…

c8f3c1e

…Test.

HelenMamontova added 5 commits January 13, 2026 18:40

The names of case changed in test suite AttributeMakeTests.

e96a9bd

The tests for methods of class Integer added to test case TypeDateInt…

170c194

…eger.

The tests for methods of class IpAddress added to test case TypeIpaddr.

31dbc9c

The tests for methods of class Encrypted added to test case

ef898c1

TypeEncrypted.

The tests for methods of class Bytes added to test case TypeOctets.

de0f9af

madf merged commit e2ee268 into madf:main Jan 14, 2026
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Сhanges in class Attribute. #64

Сhanges in class Attribute. #64

Uh oh!

HelenMamontova commented Dec 12, 2025

Uh oh!

codecov bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

madf Dec 15, 2025

Uh oh!

Uh oh!

madf Dec 15, 2025

Uh oh!

madf Dec 15, 2025

Uh oh!

madf Dec 15, 2025

Uh oh!

madf Dec 21, 2025

Uh oh!

madf Dec 21, 2025

Uh oh!

madf Dec 21, 2025

Uh oh!

madf Dec 21, 2025

Uh oh!

madf commented Dec 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Сhanges in class Attribute. #64

Сhanges in class Attribute. #64

Uh oh!

Conversation

HelenMamontova commented Dec 12, 2025

Uh oh!

codecov bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madf commented Dec 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Dec 12, 2025 •

edited

Loading