[IMPAC-739] Add new figure layout#489
Conversation
There was a problem hiding this comment.
Thanks for this, looks like it needs to be scrollable, and mainly I think the requirements need to be reviewed with @cesar-tonnoir (based on the un-used binding that were specified in the JIRA).
I need to confirm some things with Cesar myself, as currently I see two use cases for the Layouts.
-
A developer is building a custom widget template, and wants to leverage a component that handles the rendering of the layout (what you have done for "days between visits" widget).
-
No custom template is defined for a v2 bolt widget, and a generic template is to be loaded. See this PR of mine #501, which adds a table layout, which can be loaded by #484.
I think my PR is missing use case 1, and your PR is missing use case 2.
| restrict: 'E', | ||
| scope: { | ||
| content: '=' | ||
| timePeriodEnabled: '=?' |
There was a problem hiding this comment.
timePeriodEnabled, selectorList, and selectorUid isn't used anywhere.
| @@ -0,0 +1,10 @@ | |||
| .analytics .layouts.figure { | |||
There was a problem hiding this comment.
No styles are being applied to indicate this is a column or scrollable as specified in the JIRA.
In screenshot below I have added entries and they just extend the height of the widget.
4 participants
No description provided.