[IMPAC-698] Add widget average spend per customer#490
[IMPAC-698] Add widget average spend per customer#490manu-d wants to merge 1 commit intomaestrano:lmi-insightsfrom
Conversation
xaun
left a comment
xaun
left a comment
There was a problem hiding this comment.
Hey looks good, just need to fix the data-not-found directive
|
|
||
| $scope.chart = new HighchartsFactory($scope.chartId(), w.content.chart, options) | ||
|
|
||
| $scope.chart.formatters = -> |
There was a problem hiding this comment.
To save some lines, you can assign the result to a variable, and then mutate the object and return that.
defaultFormatters = $scope.chart.formatters()
$scope.chart.formatters = ->
defaultFormatters.xAxis = { new: 'opts' }
...
defaultFormatters
| </div> | ||
|
|
||
| <!-- No data found --> | ||
| <div ng-if="(isDataFound==false)" common-data-not-found on-display-alerts="onDisplayAlerts()" endpoint="::widget.category" width="::widget.width" /> |
There was a problem hiding this comment.
This is the old implementation of the data-not-found directive. I know the generator created it, but its out of date. I updated this in the generator in v1.6.9 but the lmi feature branch is behind.
The data-not-found is now a modal, so no need to show/hide content on $scope.isDataFound. Replace this directive with: <div ng-show="widget.demoData" common-data-not-found />.
Take a look at cash projection template for example, test with a bolt widget for org with no bolt data.
|
Also @manu-d, the JIRA says to load a generic Highcharts template? |
4 participants
No description provided.