Recreate stopped containers without starting#286
Open
chatziko wants to merge 1 commit into
Open
Conversation
Owner
|
Oh that's very nice! Thank you, I'll need to run some testing and should really merge #271 prior to this - I'll see if I can get them both done asap. |
Author
|
No hurry. I did some light testing (just updated one stopped container, it worked fine), but we should test more. |
Owner
Owner
|
Okay so I merged #271 to main and things got a bit more complicated to merge :) if [[ "$ContRestartStack" == true ]] || [[ "$ForceRestartStacks" == true ]]; then
${DockerBin} ${CompleteConfs} down; ${DockerBin} ${CompleteConfs} ${ContEnvs} up -d || { printf "\n%bDocker error, exiting!%b\n" "$c_red" "$c_reset" ; exit 1; }
elif [[ "$ContCreateOnly" == true ]]; then
${DockerBin} ${CompleteConfs} ${ContEnvs} create ${SpecificContainer} || { printf "\n%bDocker error, exiting!%b\n" "$c_red" "$c_reset" ; exit 1; }
else
${DockerBin} ${CompleteConfs} ${ContEnvs} up -d ${SpecificContainer} || { printf "\n%bDocker error, exiting!%b\n" "$c_red" "$c_reset" ; exit 1; }
fiThen a stopped container would fall into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR makes
-srecreate stopped containers using a simpledocker compose create, instead of doing start & stop (starting containers and forcefully stopping might have undesirable side effects).