patch: array sorting to ensure magic-sdk comes first#928
Open
0xwitty wants to merge 1 commit intomagiclabs:masterfrom
Open
patch: array sorting to ensure magic-sdk comes first#9280xwitty wants to merge 1 commit intomagiclabs:masterfrom
magic-sdk comes first#9280xwitty wants to merge 1 commit intomagiclabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
noticed the array wasn't always sorting correctly because the
sortcallback only received one parameter in some cases.this change explicitly compares two elements (
aandb) so thatmagic-sdkalways ends up at the start of the list, with everything else following.it should make the ordering consistent and predictable.