handle non-aborting unwinds from recursive-edit#426
Closed
Zoybean wants to merge 1 commit intomagit:mainfrom
Closed
handle non-aborting unwinds from recursive-edit#426Zoybean wants to merge 1 commit intomagit:mainfrom
Zoybean wants to merge 1 commit intomagit:mainfrom
Conversation
Author
|
Alas, it looks like this PR fixes my case but breaks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
recursive-editmay unwind to its caller if any of the following forms is evaluated during the recursive edit:(abort-recursive-edit)causing recursive-edit toquit(throw 'exit t), causing recursive-edit toquit(throw 'exit STRING), causing recursive-edit to(error STRING)The advice
transient--recursive-editbehaves correctly in all of the above cases, except in the 3rd case if the error signal is caught aftertransient--recursive-editunwinds and before the whole transient unwinds. In this case, the transient is left in a poor state. See #425 for more detail on reproducing this.Adding an unwind-protect to the advice resolves this, but I am unsure if any of the contents of the
condought to change. Specifically, the first arm of thecondappears to be trying to pre-empt the unwinding and tidy up, but prior to this PR, this arm does not run in an unwind anyway, and transients seem to handle unwinding from recursive-edit just fine. However, I am not confident to remove this - I do not know if there are any edge-cases that this code was added to handle.Fixes #425