Require Ruby 3.1 and excon 1.5.0 or newer - #2
Conversation
|
Hello, any reason why you closed your PR ? We have the same issue with the excon upgrade and are currently blocked by this gem, so the PR still seems relevant to me. Did you find another solution ? |
|
Hi @loicginoux , Additionally, my PR required Ruby 3.1.0, and I was concerned that would be a breaking change for anyone still on older Ruby versions. If someone wants to pick this up, a safer fix might just be updating the gemspec: I'm reopening the PR then, hopefully someone from mailchimp will answer |
|
Would love to see this merged too, but it seems like this is automatically generated repo and you need to open PRs against https://github.com/mailchimp/mailchimp-client-lib-codegen and they have a PR sitting around since November mailchimp/mailchimp-client-lib-codegen#411 |
|
Yes, please! We're waiting on this too |
Summary
This updates the Ruby client's dependency/support contract from:
to:
That makes
MailchimpTransactionalresolve a patched Excon version by default for consumers affected by current Excon security advisories, while keeping the gem's advertised Ruby support compatible with Excon 1.5.0's own Ruby requirement.Security Advisory
A downstream
bundler-auditrun reported the following issue with the previously resolved Excon version:The advisory solution requires updating Excon to
>= 1.5.0.Why
Downstream applications that need to satisfy security auditing cannot currently combine
MailchimpTransactionalwithexcon >= 1.5.0, because the released gem pins Excon below 1.0.This PR intentionally sets the minimum to
1.5.0rather than only removing the< 1upper bound, so consumers using this branch do not need an additional application-level Excon pin to avoid vulnerable versions.Because Excon 1.5.0 requires Ruby
>= 3.1.0, this PR also raisesrequired_ruby_versionto>= 3.1.0so the gemspec remains internally consistent.Generated repo note
The README says this repository is autogenerated from
mailchimp/mailchimp-client-lib-codegenand asks contributors to submit PRs/issues there. This direct PR is kept as a draft for discussion and for downstream testing of the exact dependency contract needed to resolve the audit finding.This is related to mailchimp/mailchimp-client-lib-codegen#411, but is stricter: that PR removes the Excon upper bound, while this PR requires the patched Excon version directly and updates the Ruby requirement accordingly.
Verification
ASDF_RUBY_VERSION=4.0.5 gem build MailchimpTransactional.gemspecexcon 1.5.0from the gemspec without an explicit Excon pin.MailchimpTransactional::Client#users.ping: passed withexcon 1.5.0.bundle exec bundle-audit check --update:No vulnerabilities found.Notes
This changes only gemspec dependency metadata. The runtime client already uses Excon as its HTTP transport, and the smoke test verified the existing request path with Excon 1.5.0.