Conversation
Fix callback urls in GitHub enterprise edition
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughReorganizes docs navigation to group air-gapped installation pages, adds a new Kubernetes air-gapped installation guide, updates front-matter titles for the Docker airgapped page, and bumps Plane version references from v1.13.0 to v1.14.1 in the Kubernetes doc. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
self-hosting/methods/kubernetes.mdx (2)
166-167: Avoid :latest tags for MinIO images. Pin to a known release.Using floating tags in production docs is risky for reproducibility and breakage.
- | services.minio.image | minio/minio:latest | | - | services.minio.image_mc | minio/mc:latest | | + | services.minio.image | minio/minio:RELEASE.2024-XX-XXTXX-XX-XXZ | | + | services.minio.image_mc | minio/mc:RELEASE.2024-XX-XX-XXTXX-XX-XXZ | |If you share the exact tags you validate, I can update these lines across CE/Commercial sections.
20-21: Update Helm chart version to v1.4.1
In self-hosting/methods/kubernetes.mdx (lines 20–21), change the note to:Ensure you're using Helm chart v1.4.1.This reflects the latest plane-enterprise chart release (v1.4.1 on September 8, 2025).
🧹 Nitpick comments (7)
self-hosting/methods/kubernetes.mdx (2)
29-31: Version bump to v1.14.1 — good. Also refresh the “stable” example.The warning below still references an old example version.
- When configuring the PLANE_VERSION environment variable, **do not** set it to `stable`. Always specify the latest version number (e.g., `1.8.0`). Using `stable` can lead to unexpected issues. + When configuring the PLANE_VERSION environment variable, **do not** set it to `stable`. Always specify the latest version number (e.g., `v1.14.1`). Using `stable` can lead to unexpected issues.
116-118: Minor copy fix in table cell punctuation.-| planeVersion | v1.14.1 | Yes | Specifies the version of Plane to be deployed. Copy this from `prime.plane.so.` | +| planeVersion | v1.14.1 | Yes | Specifies the version of Plane to be deployed. Copy this from `prime.plane.so`. |self-hosting/methods/airgapped-edition.mdx (1)
2-3: Title/sidebar rename LGTM; align product naming across pages.This page uses “Commercial,” while the new Kubernetes page mixes “Commercial” and “Enterprise.” Recommend standardizing terminology (“Commercial”) across both.
self-hosting/methods/airgapped-edition-kubernetes.mdx (4)
81-83: Command works; optionally preferhelm show values plane/plane-enterprisefor consistency.If you keep the local .tgz flow (good for air-gapped), this is fine as-is. No change required.
92-97: Document creating the custom S3 CA secret referenced here.Add a short snippet to create the Secret so users don’t get a missing Secret error.
s3SecretName: "s3-custom-ca" s3SecretKey: "s3-custom-ca.crt" + + # Create this secret in the target namespace before install: + # kubectl -n plane create secret generic s3-custom-ca \ + # --from-file=s3-custom-ca.crt=/path/to/your/ca.crt
176-176: Confirm canonical docs host.Link points to developers.plane.so; other links use docs.plane.so. Align to the canonical domain.
6-7: Naming consistency: “Commercial” vs “Enterprise.”This page’s intro says “Plane Enterprise,” while other pages use “Commercial.” Pick one brand term and use consistently.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
mint.json(1 hunks)self-hosting/methods/airgapped-edition-kubernetes.mdx(1 hunks)self-hosting/methods/airgapped-edition.mdx(1 hunks)self-hosting/methods/kubernetes.mdx(3 hunks)
🔇 Additional comments (3)
self-hosting/methods/airgapped-edition-kubernetes.mdx (2)
87-139: Fix YAML indentation, add planeVersion, and nest images under servicesIn self-hosting/methods/airgapped-edition-kubernetes.mdx (lines 87–139), the example should be:
planeVersion: <PLANE_VERSION> license: licenseDomain: 'plane.example.com' airgapped: enabled: true # if using a Custom Root CA for S3 storage s3SecretName: "s3-custom-ca" s3SecretKey: "s3-custom-ca.crt" services: web: image: <your-registry.com>/web-commercial:<PLANE_VERSION> api: image: <your-registry.com>/backend-commercial:<PLANE_VERSION> space: image: <your-registry.com>/space-commercial:<PLANE_VERSION> admin: image: <your-registry.com>/admin-commercial:<PLANE_VERSION> live: image: <your-registry.com>/live-commercial:<PLANE_VERSION> monitor: image: <your-registry.com>/monitor-commercial:<PLANE_VERSION> silo: image: <your-registry.com>/silo-commercial:<PLANE_VERSION> iframely: image: <your-registry.com>/iframely:v1.2.0 redis: image: <your-registry.com>/valkey:7.2.5-alpine postgres: image: <your-registry.com>/postgres:15.7-alpine rabbitmq: image: <your-registry.com>/rabbitmq:3.13.6-management-alpine minio: image: <your-registry.com>/minio:latest image_mc: <your-registry.com>/mc:latest env: storageClass: ''Manually verify that
planeVersion,license.licenseDomain,airgapped.*, and eachservices.<name>.imagekey match your Helm chart’s values definitions.
69-76: Clarify image distribution: push to a registry reachable by all cluster nodes and configure imagePullSecrets# Load each image into Docker docker load -i <plane-images>.tar # Tag and push each image to your private registry docker tag <image-name> <your-registry>/<image-name> docker push <your-registry>/<image-name>Add to your chart’s values (adjust key if chart differs):
global: imagePullSecrets: - name: regcredPlease confirm your Helm chart supports
global.imagePullSecrets(or update to the correct values field).mint.json (1)
75-82: Navigation grouping LGTM.The “Airgapped Edition” group with Docker and Kubernetes pages reads well and matches the new sidebar titles.
| wget https://github.com/makeplane/helm-charts/releases/download/plane-enterprise-1.4.1/plane-enterprise-1.4.1.tgz | ||
|
|
||
| # Using curl | ||
| curl -L -O https://github.com/makeplane/helm-charts/releases/download/plane-enterprise-1.4.1/plane-enterprise-1.4.1.tgz | ||
| ``` |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Hardcoded chart version — verify recency and consider bundling chart for fully air-gapped installs.
- Confirm 1.4.1 is the latest chart.
- For fully air-gapped workflows, consider shipping this .tgz inside the offline bundle to avoid requiring internet even on the jump host.
🌐 Web query:
Is plane-enterprise Helm chart v1.4.1 the latest release as of September 9, 2025?
💡 Result:
No. I couldn't find a plane-enterprise v1.4.1 as the latest — the makeplane/helm-charts releases show plane-enterprise up to v1.1.2, and the official Plane Helm repo/docs point to the chart at helm.plane.so (use helm repo update + helm search repo plane/plane-enterprise to confirm locally). [1][2]
Sources:
- makeplane/helm-charts releases (plane-enterprise tags). [1]
- Plane Helm repo / Kubernetes install docs (helm.plane.so). [2]
Update hardcoded chart version and bundle for air-gapped installs
Replace plane-enterprise-1.4.1.tgz with the actual latest chart (as of Sep 9, 2025 it’s v1.1.2—verify via helm repo update && helm search repo plane/plane-enterprise), and include that .tgz in your offline bundle so no internet access is required on the jump host.
🤖 Prompt for AI Agents
In self-hosting/methods/airgapped-edition-kubernetes.mdx around lines 21 to 25,
the docs hardcode a specific chart file name (plane-enterprise-1.4.1.tgz);
update the reference to the current chart version (verify latest with helm repo
update && helm search repo plane/plane-enterprise) and replace the hardcoded
filename with the verified latest filename (e.g., plane-enterprise-v1.1.2.tgz if
confirmed), and update the instructions to state that the matching .tgz must be
included in the offline bundle on the jump host so no internet access is
required during installation.
| helm install plane-app plane-enterprise-1.4.1.tgz \ | ||
| --create-namespace \ | ||
| --namespace plane \ | ||
| -f custom-values.yaml \ | ||
| --timeout 10m \ | ||
| --wait \ | ||
| --wait-for-jobs | ||
| ``` |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Include planeVersion in install or values.
Your install command doesn’t set planeVersion; ensure it’s in custom-values.yaml (see prior comment) or add a flag.
- helm install plane-app plane-enterprise-1.4.1.tgz \
+ helm install plane-app plane-enterprise-1.4.1.tgz \
--create-namespace \
--namespace plane \
-f custom-values.yaml \
+ --set planeVersion=v1.14.1 \
--timeout 10m \
--wait \
--wait-for-jobs(Use one source of truth to avoid drift; prefer values file.)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| helm install plane-app plane-enterprise-1.4.1.tgz \ | |
| --create-namespace \ | |
| --namespace plane \ | |
| -f custom-values.yaml \ | |
| --timeout 10m \ | |
| --wait \ | |
| --wait-for-jobs | |
| ``` | |
| helm install plane-app plane-enterprise-1.4.1.tgz \ | |
| --create-namespace \ | |
| --namespace plane \ | |
| -f custom-values.yaml \ | |
| --set planeVersion=v1.14.1 \ | |
| --timeout 10m \ | |
| --wait \ | |
| --wait-for-jobs |
🤖 Prompt for AI Agents
In self-hosting/methods/airgapped-edition-kubernetes.mdx around lines 144 to
151, the helm install example does not set planeVersion; update the installation
to use a single source of truth by adding planeVersion: "<desired-version>" to
custom-values.yaml (or, if you must override, add --set
planeVersion=<desired-version> to the helm command), and ensure the value
matches the version referenced elsewhere in the docs to avoid drift.
| ```yaml | ||
| # Example of image updates in custom-values.yaml | ||
| license: | ||
| licenseDomain: 'plane.example.com' |
| licenseDomain: 'plane.example.com' | ||
|
|
||
| airgapped: | ||
| enabled: true |
There was a problem hiding this comment.
TAB is required for
enabled: true
s3SecretName: "s3-custom-ca"
s3SecretKey: "s3-custom-ca.crt"
| image_mc: <your-registry.com>/mc:latest | ||
|
|
||
| env: | ||
| storageClass: '' |
3 participants
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit
New Features
Documentation