fix: disable react-in-jsx-scope rule in oxlint config#8682
fix: disable react-in-jsx-scope rule in oxlint config#8682darkingtail wants to merge 1 commit intomakeplane:previewfrom
Conversation
After makeplane#8677 replaced ESLint with OxLint, the react-in-jsx-scope rule was not disabled. This causes all commits touching JSX files to fail the pre-commit hook (oxlint --deny-warnings). React 17+ uses automatic JSX runtime so explicit React imports are not required. Fixes makeplane#8681
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
"react/react-in-jsx-scope": "off"to.oxlintrc.jsonimport Reactis not requiredProblem
After #8677, the pre-commit hook (
oxlint --fix --deny-warnings) fails on every commit that touches a JSX/TSX file:This blocks all local development commits.
Fix
One-line change in
.oxlintrc.json:Fixes #8681
Summary by CodeRabbit