Skip to content

feat: display errors better #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrkickling merged 1 commit into from
Jan 23, 2026
Merged

feat: display errors better #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions mal_gui/main_window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,21 +736,26 @@ def save_as_scenario(self):
self.scene.scenario.is_observable.to_dict()
)

scenario = Scenario(
lang_file=self.lang_file_path,
model=self.scene.model,
agent_settings=agents,
rewards=rewards,
false_negative_rates=false_negative_rates,
false_positive_rates=false_positive_rates,
actionable_steps=is_actionable,
observable_steps=is_observable,
)
scenario.save_to_file(file_path)
if hasattr(self, '_lang_file'):
scenario_dict = yaml.safe_load(open(file_path, "r"))
scenario_dict["lang_file"] = self._lang_file
yaml.safe_dump(scenario_dict, open(file_path, "w"))
try:
scenario = Scenario(
lang_file=self.lang_file_path,
model=self.scene.model,
agent_settings=agents,
rewards=rewards,
false_negative_rates=false_negative_rates,
false_positive_rates=false_positive_rates,
actionable_steps=is_actionable,
observable_steps=is_observable,
)
scenario.save_to_file(file_path)

if hasattr(self, '_lang_file'):
scenario_dict = yaml.safe_load(open(file_path, "r"))
scenario_dict["lang_file"] = self._lang_file
yaml.safe_dump(scenario_dict, open(file_path, "w"))
except Exception as e:
self.show_error_popup("Could not save scenario: " + str(e))


def quitApp(self):
self.app.quit()
Expand Down