Open
Conversation
Author
|
Current status: run @ana-cc What sort of delays do we need, and where do we need them, to make sure we are within limits for ICMP rate-limiting? |
irl
force-pushed
the
task/103
branch
2 times, most recently
from
ffa72d1 to
74d5954
Compare
Contributor
|
@irl are you planning to merge this PR any time soon? |
Member
|
I am in Mexico all next week and am currently preparing for that, I won't have time to merge this PR this month. |
Contributor
|
Okay. What's missing to merge this PR? |
Member
|
merger and combiner are not implemented, only worker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to deal with adding a standalone traceroute command.
The base plugin classes are extended to have multiple worker flavours associated with them by adding a keyword argument to the
start()function.All the standalone traceroutes are based on packet forging, but the traceroute traffic marking and transmission will accept a captured template instead so that this code may be easily extended to implement #111.
When complete, this should fix #103 and #169.
Expect heavy rebasing to happen while this branch is still WIP.