You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
you are right. This PR addresses only a better support to cocoapods. My thought was:
• before do any changes maybe it could be worth to fix the current workspace (since when you download it it does not match the usual cocoapods standards)
• the original project still works, you need to run pod install (see http://guides.cocoapods.org/making/using-pod-lib-create). We can include Podfile.lock and Pods if you want to save the user from doing this
Last bit, only to give you a better picture, about other changes I made so far and I have not included in the PR:
• return a reference to the AFHTTPRequestOperation (then we can cancel them, for instance)
• extension that returns "open now" and "opening hours" from a detail response
Many thanks for your time and thank you for your very nice library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• fix sample project - it now uses FTGooglePlacesAPI as pod
• fix tests