fix(knowledge): align build.py version with Makefile VERSION env var#70
Merged
Conversation
build.py was independently calling git describe, producing e.g. 'v1.3.5',
while the Makefile TARGET used the externally-passed VERSION ('1.3.5' after
stripping the v prefix). mvn deploy:deploy-file then failed because the
file it expected did not exist.
Pass VERSION through as MPE_VERSION env var so build.py uses the same
version string as the Makefile TARGET, with git describe as the fallback
for local builds where VERSION is not set.
Signed-off-by: Greg Haskins <greg@manetu.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.py was independently calling git describe, producing e.g. 'v1.3.5', while the Makefile TARGET used the externally-passed VERSION ('1.3.5' after stripping the v prefix). mvn deploy:deploy-file then failed because the file it expected did not exist.
Pass VERSION through as MPE_VERSION env var so build.py uses the same version string as the Makefile TARGET, with git describe as the fallback for local builds where VERSION is not set.