OVS review #10
Open
OVS review #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logical-interface
…rail-controller into psethi_openvswitch
1. Avoid agent crash when dataplane_ip or management_ip is not specified 2. Add introspect to show VMI and tag for logical-port 3. Create VlanLogicalPortEntry
since junos donot support colon(:) for logical switch name. Change to remove logical switch name from key of vlan_port_binding.
Move ovs_peer.cc and .h to ovsdb_client/ directory
…rail-controller into psethi_openvswitch
And add routes for export to bgp.
Skipping routes imported from same ovsdb.
1. Modify the logic used to identify routes that must be exported to controller In existing design, controller-peer looks at the peer-type to decide if path added by it can be exported to controller. Any new type of peer will need modifying this code as well. The design is modified such that, a virtual function in peer specifies if the routes added by peer should be exported to controller. 2. Modify the logic to set the nexthop-ip in route exported to controller. In existing design, agent always sets IP address of VHOST to be the nexthop-ip in the route exported to controller. In case of OVS, agent is exporting route on-behalf of the ToR. In this case the nexthop should actually be that of ToR. The design is modified to get the nexthop-ip from peer Only EVPN routes are using the new API. L3 and Mcast routes will be modified later to use the new API. 3. Add skeletal code for UT of OVS-Peer
replace printf with OVSDB_TRACE.
Issue: ------ The retract string bgp for EVPN routes is of format, <vn-id>-<mac>,<ip> The current code for marsing mac-address only strips vn-id and tries to decode MAC address from string <mac>,<ip>. The decode fails due to presence of IP address. Fix: --- Strip the IP address and additional "," using strtok_r and parse the MAC address
Separating OvsdbClientSession to separate file. Adding some more traces. Re-try on add failures from ovsdb.
…rail-controller into psethi_openvswitch
1) DHCP handling - reply to dhcp request from baremetals behind TOR, IP-MAC binding received from VMI created for baremetal. 2) Multicast TOR and subscribe for multicast fabric tree when TOR is added (even in absence of any local vm interface) 3) VM interface creation binded to TOR logical ports.
Handle reuse of physical locator for multicast remote mac.
…rail-controller into psethi_openvswitch
…rail-controller into psethi_openvswitch
Change-Id: I95a9bb9f5a4200ce60e26ac0300f893d474ada0c
names stats table, so that it can be queried to get a list of ModuleId's occuring in any time range. Closes-Bug:#1360414 Change-Id: I8256ff794850bd321ad8fe543fa83b8356c5f21b
Add a link from loadbalancer pool to virtual machine interface(VMI). VMI is linked to a logical interface of a physical router where the configuration is stored. Change-Id: I1f708e12ad0bef87c33da34b189d1c86574c4b81 Closes-Bug: #1381775
…send a subnet_uuid, we were allocating a new UUID. If the subnet already exists, we should reuse the subnet_uuid. Now, we read from cassandra before generating a new UUID. Change-Id: I13426663c8a2a8e79fbf170dffb81c726506cee1 Closes-Bug: 1381779 (cherry picked from commit c2f71af5f2e9a6f31ce65e48c0e4a4c62e82f0c8)
…arlier version Change-Id: Ic39a4e1fc46c5259f3a5de69e778ac1352dc034d
Collaborator
There was a problem hiding this comment.
Maintain DBSTate to see if you have already added entry or not to avoid duplicate processing.
Collaborator
There was a problem hiding this comment.
Add comments on what is ClonedLocalPath here?
added 2 commits
November 14, 2014 01:29
earlier if there is a temp entry created due to reference, we always fail to add the corresponding ovsdb entry.
…rail-controller into psethi_openvswitch
Collaborator
There was a problem hiding this comment.
Should compare with agent_name() instead of host_name()
interface * Delete all ARP route dependent, when resolve route gets deleted
Display stats in introspect.
…olist. Same was observed in change of address of TOR. Added support for both.
fix post delete callback. adding introspect for other ovsdb tables.
…rail-controller into psethi_openvswitch
…read. adding Ovsdb Pkt trace.
OVS fails to remove exported route path. Fix: while deleting the exported route path use direct reference instead of find.
…rail-controller into psethi_openvswitch
…path is gone as it happens when IPAM is gone.
Conflicts: src/vnsw/agent/oper/vm_interface.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.