Skip to content

Elina #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mannsn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Elina #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae3df5
elina
mannsn Feb 3, 2025
0299092
demo
mannsn May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ <h1>Guessing Game</h1>
</p>
</div>
<button id="reset">Reset</button>

</main>
<script src="index.js"></script>
</body>
</html>
</html>
38 changes: 25 additions & 13 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,31 @@ const correctMessage = document.getElementById('correct');

let targetNumber;
let attempts = 0;
const maxNumberOfAttempts = 5;
//third bug (was const I did let)
let maxNumberOfAttempts = 5;


// Returns a random number from min (inclusive) to max (exclusive)
// Usage:
// > getRandomNumber(1, 50)
// <- 32
// > getRandomNumber(1, 50)
// <- 11

function getRandomNumber(min, max) {
return Math.floor(Math.random() * (max - min)) + min;
}

//eigth bug. Firstly we have to declare function and then call it.
function hideAllMessages() {
//fourth bug (I added "-1")
for (let elementIndex = 0; elementIndex <= messages.length - 1; elementIndex++) {
messages[elementIndex].style.display = "none";
}
}

//make a change

function checkGuess() {
// Get value from guess input element
const guess = parseInt(guessInput.value, 10);
Expand All @@ -43,16 +56,17 @@ function checkGuess() {
if (guess < targetNumber) {
tooLowMessage.style.display = '';
} else {
tooLowMessage.style.display = '';
//fifth bug (both were "tooLowMessage.style.display")
tooHighMessage.style.display = '';
}

const remainingAttempts = maxNumberOfAttempts - attempts;

numberOfGuessesMessage.style.display = '';
numberOfGuessesMessage.innerHTML = `You guessed ${guess}. <br> ${remainingAttempts} guesses remaining`;
}

if (attempts ==== maxNumberOfAttempts) {
//first bug
if (attempts === maxNumberOfAttempts) {
submitButton.disabled = true;
guessInput.disabled = true;
}
Expand All @@ -62,22 +76,20 @@ function checkGuess() {
resetButton.style.display = '';
}

function hideAllMessages() {
for (let elementIndex = 0; elementIndex <= messages.length; elementIndex++) {
messages[elementIndex].style.display = 'none';
}
}

funtion setup() {
//second bug (misspelling "function")
function setup() {
// Get random number
targetNumber = getRandomNumber(1, 100);
console.log(`target number: ${targetNumber}`);

// Reset number of attempts
maxNumberOfAttempts = 0;
//sixth bug (was "0" I did "5")
maxNumberOfAttempts = 5;

// Enable the input and submit button
submitButton.disabeld = false;
//seventh bug (was "disabeld" I did "disabled")
submitButton.disabled = false;
guessInput.disabled = false;

hideAllMessages();
Expand All @@ -87,4 +99,4 @@ funtion setup() {
submitButton.addEventListener('click', checkGuess);
resetButton.addEventListener('click', setup);

setup();
setup();