Conversation
stop propagation of click event and adjust layout enable geojson export Adjust Layout of export checkbox export button only when export allowed make export method overridable refactor adjust geometryexport
|
| type: 'button', | ||
| title: Mapbender.trans('mb.digitizer.toolset.exportSelected') | ||
| }) | ||
| .addClass('btn btn-default -fn-export-selected') |
There was a problem hiding this comment.
The button's style does not fit into the style of the other buttons:
Also, it does not really fit into the geometry manipulation group. I'd either put it into the first button group or make it its own group.
|
|
||
| {%- block table_buttons -%} | ||
| <button class="-fn-check-for-export btn" title="{{ 'mb.digitizer.feature.export.check' | trans }}"> | ||
| <i class="fa fas fa-square-o"></i> |
There was a problem hiding this comment.
square-o existed in Font Awesome 4, but was already removed in Font Awesome 5. https://fontawesome.com/search?q=square&o=r&ic=free
There was a problem hiding this comment.
I changed it to fa-square
| revert.geometry: Geometrieänderung zurücknehmen | ||
| intersection.error: Ungültige Geometrie | ||
| feature: | ||
| export: |
There was a problem hiding this comment.
they are already there, just look one line below :-)
There was a problem hiding this comment.
I mean in English, French, etc.
| registerButtonEvents: function(schema, $table) { | ||
| var self = this; | ||
|
|
||
| $table.on('click', 'tbody > tr .-fn-check-for-export', function(e) { |
There was a problem hiding this comment.
why the specific tbody > tr and not just the .fn-check-for-export?
There was a problem hiding this comment.
because I did not want to break the pattern used for the other click events
There was a problem hiding this comment.
Hm, I see. I'd vote for removing the tbody > tr for all of the click listeners, the more separation between markup and logic the more maintainable the code
|
For discussion
|
astroidex
left a comment
astroidex
left a comment
There was a problem hiding this comment.
we should work on a centra exportfactory that is used by all the elements.
3 participants
stop propagation of click event and adjust layout
enable geojson export
Adjust Layout of export checkbox
export button only when export allowed
make export method overridable
refactor
adjust geometryexport