Add new property: model-allow-density-reduction
#13595
Closed
+1,530
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underoot
previously approved these changes
Dec 1, 2025
ibesora
changed the title
model-allow-density-reduction
underoot
previously approved these changes
Dec 1, 2025
JoshuaJMoore
approved these changes
Dec 5, 2025
|
Thanks @ibesora |
underoot
approved these changes
Dec 8, 2025
Contributor
Author
|
This has been imported to the private repo and expanded so |
mapbox-github-ci-writer-public-1 bot
pushed a commit
to mapbox/mapbox-maps-ios
that referenced
this pull request
Dec 10, 2025
This PR fixes the merge conflicts found in mapbox/mapbox-gl-js#13433 which I couldn't address directly there (I suppose due to branch protections on the original reporter branch), adds a new render test to cover this behaviour and marks `model-allow-density-reduction` as `experimental`. All credit goes to @JoshuaJMoore who did the initial implementation Closes [MAPS3D-2107](https://mapbox.atlassian.net/browse/MAPS3D-2107) and [GLJS-1561](https://mapbox.atlassian.net/browse/GLJS-1561) ## Launch Checklist - [ ] Make sure the PR title is descriptive and preferably reflects the change from the user's perspective. - [ ] Add additional detail and context in the PR description (with screenshots/videos if there are visual changes). - [ ] Manually test the debug page. - [ ] Write tests for all new functionality and make sure the CI checks pass. - [ ] Document any changes to public APIs. - [ ] Post benchmark scores if the change could affect performance. - [ ] Tag `@mapbox/map-design-team` `@mapbox/static-apis` if this PR includes style spec API or visual changes. - [ ] Tag `@mapbox/gl-native` if this PR includes shader changes or needs a native port. - [ ] Tag `@mapbox/gl-native` if this PR disables any test because it also needs to be disabled on their side. - [ ] Create a ticket for `gl-native` to groom in the [MAPSNAT JIRA queue](https://mapbox.atlassian.net/jira/software/c/projects/MAPSNAT/list) if this PR includes shader changes or features not present in the native side or if it disables a test that's not disabled there. -- > [!NOTE] > This PR was imported from the public repo and closes: mapbox/mapbox-gl-js#13595 > ``` > <public>Add new property: `model-allow-density-reduction` (h/t @JoshuaJMoore) (public-13595)</public> > ``` Author: Isaac Besora Vilardaga <isaac.besora@gmail.com> cc @mapbox/gl-js [MAPS3D-2107]: https://mapbox.atlassian.net/browse/MAPS3D-2107?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [GLJS-1561]: https://mapbox.atlassian.net/browse/GLJS-1561?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ cc @mapbox/maps-android cc @mapbox/maps-ios cc @mapbox/sdk-ci --------- Co-authored-by: Isaac Besora Vilardaga <isaac.besora@gmail.com> Co-authored-by: Changelog autocreator bot <actions@github.com> GitOrigin-RevId: 64bb4e75904e023db952a4054f4a575a9628c196
mapbox-github-ci-writer-public-1 bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
@JoshuaJMoore) (#13595) GitOrigin-RevId: 64bb4e75904e023db952a4054f4a575a9628c196
mapbox-github-ci-writer-public-1 bot
pushed a commit
to mapbox/mapbox-maps-android
that referenced
this pull request
Dec 10, 2025
This PR fixes the merge conflicts found in mapbox/mapbox-gl-js#13433 which I couldn't address directly there (I suppose due to branch protections on the original reporter branch), adds a new render test to cover this behaviour and marks `model-allow-density-reduction` as `experimental`. All credit goes to @JoshuaJMoore who did the initial implementation Closes [MAPS3D-2107](https://mapbox.atlassian.net/browse/MAPS3D-2107) and [GLJS-1561](https://mapbox.atlassian.net/browse/GLJS-1561) ## Launch Checklist - [ ] Make sure the PR title is descriptive and preferably reflects the change from the user's perspective. - [ ] Add additional detail and context in the PR description (with screenshots/videos if there are visual changes). - [ ] Manually test the debug page. - [ ] Write tests for all new functionality and make sure the CI checks pass. - [ ] Document any changes to public APIs. - [ ] Post benchmark scores if the change could affect performance. - [ ] Tag `@mapbox/map-design-team` `@mapbox/static-apis` if this PR includes style spec API or visual changes. - [ ] Tag `@mapbox/gl-native` if this PR includes shader changes or needs a native port. - [ ] Tag `@mapbox/gl-native` if this PR disables any test because it also needs to be disabled on their side. - [ ] Create a ticket for `gl-native` to groom in the [MAPSNAT JIRA queue](https://mapbox.atlassian.net/jira/software/c/projects/MAPSNAT/list) if this PR includes shader changes or features not present in the native side or if it disables a test that's not disabled there. -- > [!NOTE] > This PR was imported from the public repo and closes: mapbox/mapbox-gl-js#13595 > ``` > <public>Add new property: `model-allow-density-reduction` (h/t @JoshuaJMoore) (public-13595)</public> > ``` Author: Isaac Besora Vilardaga <isaac.besora@gmail.com> cc @mapbox/gl-js [MAPS3D-2107]: https://mapbox.atlassian.net/browse/MAPS3D-2107?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [GLJS-1561]: https://mapbox.atlassian.net/browse/GLJS-1561?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ cc @mapbox/maps-android cc @mapbox/maps-ios cc @mapbox/sdk-ci --------- Co-authored-by: Isaac Besora Vilardaga <isaac.besora@gmail.com> Co-authored-by: Changelog autocreator bot <actions@github.com> GitOrigin-RevId: 64bb4e75904e023db952a4054f4a575a9628c196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the merge conflicts found in #13433 which I couldn't address directly there (I suppose due to branch protections on the original reporter branch), adds a new render test to cover this behaviour and marks
model-allow-density-reductionasexperimental.All credit goes to @JoshuaJMoore who did the initial implementation
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.@mapbox/gl-nativeif this PR includes shader changes or needs a native port.@mapbox/gl-nativeif this PR disables any test because it also needs to be disabled on their side.gl-nativeto groom in the MAPSNAT JIRA queue if this PR includes shader changes or features not present in the native side or if it disables a test that's not disabled there.