fix MlWmsLoader reinitialization on prop change bug#255
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a reinitialization bug in the MlWmsLoader component that occurred when props changed. The fix refactors how default props are merged with user-provided props, moving from object spreading to useMemo hooks for stable references. Additionally, it improves CRS/SRS handling in GetFeatureInfo requests and removes an unused utility function.
Changes:
- Refactored prop merging to use
useMemofor URL parameter objects to prevent unnecessary re-renders - Enhanced GetFeatureInfo bbox calculation to support EPSG:4326/CRS:84 coordinate systems
- Removed unused
LngLatimport andlngLatToMetersutility function
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/react-maplibre/src/components/MlWmsLoader/MlWmsLoader.tsx | Refactored prop handling with useMemo, improved CRS handling in GetFeatureInfo, removed unused utility function |
| packages/react-maplibre/src/components/MlWmsLoader/MlWmsLoader.stories.tsx | Added new story demonstrating custom feature info handling with sidebar display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-maplibre/src/components/MlWmsLoader/MlWmsLoader.tsx
Outdated
Show resolved
Hide resolved
packages/react-maplibre/src/components/MlWmsLoader/MlWmsLoader.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.